This repository has been archived by the owner on May 31, 2024. It is now read-only.
Remove dependency on unsupported k8s.io/kubernetes library
#457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Katrina Rogan <[email protected]>
katrogan
requested review from
kumare3,
EngHabu and
wild-endeavor
as code owners
katrogan
changed the title
k8s.io/kubernetes library
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #457 +/- ##
==========================================
- Coverage 67.70% 67.69% -0.01%
==========================================
Files 148 148
Lines 6641 6639 -2
==========================================
- Hits 4496 4494 -2
Misses 1855 1855
Partials 290 290
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wild-endeavor
previously approved these changes
Jan 22, 2024
Signed-off-by: Katrina Rogan <[email protected]>
wild-endeavor
approved these changes
Jan 22, 2024
wild-endeavor
previously approved these changes
Jan 22, 2024
Signed-off-by: Katrina Rogan <[email protected]>
wild-endeavor
approved these changes
Jan 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
See kubernetes/kubernetes#79384 (comment) for background,
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
NA
Follow-up issue
NA